-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Remove validation related methods #6617
Conversation
0f0e90f
to
70666f2
Compare
@tambait In order to reduce conflict, you should always wait for the merge in 3.x, then for the 3.x merge into master before doing the PR in master |
Could you please rebase your PR and fix merge conflicts? |
5e165e5
to
c5da28f
Compare
c5da28f
to
66a1fd1
Compare
Could you please rebase your PR and fix merge conflicts? |
1c562e6
to
5a7383a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say you can also remove
- The property
protected $validator;
of the AbstractAdmin - The set/getValidator method of the AbstractAdmin and the interface
- All the 4
class_exists(\Sonata\Form\Validator\ErrorElement::class);
occurences ->scalarNode('validator')->defaultNull()->end()
in DependencyInjection/Configuration- All the validator occurence in the doc
- All the 'validator' occurence in AddDependencyCallsCompilerPass
I don't see these appearing in the master branch only in 3.x, so should I just add notice in 3.x for this to be removed in next major? Also, should |
If it's already removed, nothing to do ;)
I don't think so. These validators are used for the commands, not the admin. |
Could you please rebase your PR and fix merge conflicts? |
@VincentLanglet |
Oh yes indeed, let's ask @franmomu A review for your PR introducing deprecations :p |
Subject
Closes #6233
Changelog