Add deprecation when injecting registry in command

[VincentLanglet]

Subject

I am targeting this branch, because BC.

Some deprecation and some tests updates were missing in #6413

Changelog

### Deprecated
- Deprecate Passing a third argument to `GenerateObjectAclCommand::__construct()`

[franmomu]

The problem I see with this is that as it is, is that it will throw an unavoidable deprecation because doctrine is still being injected:

SonataAdminBundle/src/Resources/config/commands.php

Line 58 in 0813269

(new ReferenceConfigurator('doctrine'))->nullOnInvalid(),

If we don't pass it, it will be BC-break (because the user_model won't work). So maybe we can create an @internal setter (to be removed in next major) and call it in the definition and don't pass the $registry in the constructor.

[VincentLanglet]

So maybe we can create an @internal setter (to be removed in next major) and call it in the definition and don't pass the $registry in the constructor.

Sure. Could you give me the code to write in the commands.php ? @franmomu

[franmomu]

I guess this would work:

->set(GenerateObjectAclCommand::class, GenerateObjectAclCommand::class)
    ->public()
    ->tag('console.command')
    ->args([
        new ReferenceConfigurator('sonata.admin.pool'),
        []
    ])
    ->call('setRegistry', [(new ReferenceConfigurator('doctrine'))->nullOnInvalid()])

[VincentLanglet]

Thanks @franmomu, I've made the changes

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[OskarStark]

Suggested change

	class DeprecatedGenerateObjectAclCommandTest extends TestCase
	final class DeprecatedGenerateObjectAclCommandTest extends TestCase

[OskarStark]

Just a minor comment

[VincentLanglet]

I made the requested change @OskarStark

[greg0ire]

Is that normal? If not, why did the test pass? They don't pass when trying to merge this up.

[VincentLanglet]

Indeed, %s() is weird... I think I have made a mistake