Deprecate using shortcut notation for user_model in favor of FQCN #6413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
reviewed
Sep 24, 2020
franmomu
force-pushed
the
deprecate_registry_in_command
branch
from
60942b7 to
2eaee1e
Compare
phansys
requested changes
Sep 24, 2020
franmomu
force-pushed
the
deprecate_registry_in_command
branch
from
2eaee1e to
e6718a2
Compare
phansys
previously approved these changes
Sep 25, 2020
jordisala1991
requested changes
Sep 25, 2020
Instead of using shortcut notation for referring a user entity, now we ask for the FQCN which allows us to not use a ManagerRegistry dependency.
franmomu
force-pushed
the
deprecate_registry_in_command
branch
from
e6718a2 to
c0428fe
Compare
phansys
approved these changes
Sep 25, 2020
jordisala1991
approved these changes
Sep 25, 2020
|
Thank you @franmomu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Ref: #6407 (comment)
If we use FQCN notation for the
user_modeloption inGenerateObjectAclCommand, there is no need for the$registrydependency.I am targeting this branch, because these changes are BC.
Changelog
To do