-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Prioritize jQuery UI scripts in "assets.javascripts" config in order to avoid initialization issues #5087
[bugfix] Prioritize jQuery UI scripts in "assets.javascripts" config in order to avoid initialization issues #5087
Conversation
bfdb9a2
to
41c1232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can't know if this will break something else
I'm afraid we can't. |
we changed this a few PRs ago... does this PR revert the older one? |
That seems to be true. Then, I'll try to make some tests around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent accidental merge
and it looked familiar but I wasn't sure 😅 |
@verheyenkoen, are you sure the only way to fix the issue you've reported on #5047 is to change the order of the scripts? AFAIK, the embedded version of jQuery doesn't support |
@phansys I don't know. This is a fix I found. If it's no good I guess we have to revert it. |
Ok, let me do some checks in order to determine how we could make both fixes to co-exist. |
AFAIK, there is no way to solve both issues without reverting the changes at #5047 and using some of the alternatives proposed on SO (https://stackoverflow.com/a/20391739 by instance). Moreover, I don't know if the only bug that PR fixes is the visibility of the close button or if there are other issues covered by that modification. |
Any idea on how to deal with this one @greg0ire ? |
Pick the lesser of the 2 bugs? |
Then, probably this bug is bigger than the other? @phansys the StackOverflow you linked covers the other bug report? |
Please edit the docs like the other PR: https://github.com/sonata-project/SonataAdminBundle/pull/5047/files#diff-e252be027e26148c11d971dc969f4be0R205 |
41c1232
to
07ee047
Compare
I think not, because I don't know how to provide the In my particular use case, my app was using Update at |
…in order to avoid initialization issues
07ee047
to
62a6d89
Compare
We might merge this one after all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge it and wait for people to scream?
Yes 👍 |
Thank you @phansys |
…in order to avoid initialization issues (sonata-project#5087)
I am targeting this branch, because this guards BC.
Changelog
Todo:
Check if changes made at 359ce81 can be reverted (usingnoConflict()
instead).