Fix for hidden jQuery UI dialog close button #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunicmarko20
previously approved these changes
Mar 30, 2018
|
Please apply the patch provided by flintCI |
|
@jordisala1991 Any idea what went wrong now? |
|
Before, you probably had some extra whitespaces on a empty line. Now, for some reason, flintCI does not want to work |
jordisala1991
approved these changes
Mar 30, 2018
|
@jordisala1991 I know the feeling. |
kunicmarko20
approved these changes
Mar 30, 2018
|
I guess we can merge it without flintCI? |
|
We can merge without flint approval, because we already saw it fixed, and the PR is really small |
|
Thank you @verheyenkoen |
1 task
|
This change reintroduce the problem with tooltips everywhere which (fixed in #3153). |
|
We have #5087 which basically reverts this one, does it fix the issue? |
pestaa
pushed a commit
to Crosssec/SonataAdminBundle
that referenced
this pull request
Aug 6, 2018
* Moved bootstrap dependency up to fix jQuery UI dialog close button issue (sonata-project#4511) * Applied Flint CI patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because it is a patch.
Closes #4511
Changelog
Subject
When using the jQuery UI dialog window, the close button ("x") in the top right corner was missing because of interference with bootstrap. Reordering the javascript dependency files fixed this issue.