euler1d gui and plotting area user experience enhancement #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j8xixo12
commented
Apr 10, 2024
Comment on lines
-548
to
-567
| def save_file(self): | ||
| """ | ||
| Toolbar action callback, that use pixmap to store plotting area | ||
| and open a dialog that allows user to decide where to store the | ||
| figure file. | ||
|
|
||
| :return: None | ||
| """ | ||
| fig = QPixmap(self.plot_holder.plot.size()) | ||
| self.plot_holder.plot.render(fig) | ||
|
|
||
| options = QFileDialog.Options() | ||
| options |= QFileDialog.DontUseNativeDialog | ||
| fileName, _ = QFileDialog.getSaveFileName(None, "Save file", "", | ||
| "All Files (*)", | ||
| options=options) | ||
|
|
||
| if fileName != "": | ||
| fig.save(fileName, "JPG", 100) | ||
|
|
There was a problem hiding this comment.
Using matplotlib built-in toolbar, it also contain save file button
so remove self-development save file callback.
Comment on lines
+853
to
+876
| with (Modal(self.state("plot_config_open"), | ||
| title="Plot configuration") | ||
| .open(self.on_open) | ||
| .close(self.on_close)): | ||
| with VBox(): | ||
| with HBox(): | ||
| Label("Layout selection") | ||
| Button("Grid").click(lambda: self.app.grid_layout()) | ||
| Button("Single").click((lambda: | ||
| self.app.single_layout())) | ||
| Label("Data line configuration") | ||
| Table(self.plot_config) | ||
| Button("Save").click(lambda: self.app.update_layout()) |
There was a problem hiding this comment.
Add a modal window that allows the user to select which data line is plotted and adjust the upper/bottom limit of the y-axis. Additionally, it should be able to switch the plot layout.
Comment on lines
+594
to
+604
| y_upper_lim_max = max(y_upper_lim_max, data.y_upper_lim) | ||
| y_bottom_lim_min = min(y_bottom_lim_min, data.y_bottom_lim) |
Comment on lines
+573
to
+583
| y_upper_lim_max = 0.0 | ||
| y_bottom_lim_min = sys.float_info.max |
There was a problem hiding this comment.
Using the max and min limit as the plotting figure.
Comment on lines
+84
to
+85
| y_upper_lim: float = 0.0 | ||
| y_bottom_lim: float = 0.0 |
There was a problem hiding this comment.
added 2 float as Quantity Line's attribute to record current data line y axis upper / bottom limit.
j8xixo12
force-pushed
the
euler1d_enhance
branch
from
ea43d05
to
f9c053e
Compare
j8xixo12
commented
Apr 11, 2024
Comment on lines
+134
to
+143
| m_eulerMenu = m_mainWindow->menuBar()->addMenu(QString("Euler")); | ||
|
|
||
| { | ||
| auto app_name = QString("euler1d"); | ||
| auto * action = new RAppAction( | ||
| QString("Load ") + app_name, | ||
| QString("Load ") + app_name, | ||
| QString("modmesh.app.") + app_name); | ||
| m_eulerMenu->addAction(action); | ||
| } |
There was a problem hiding this comment.
Add Euler into modmesh main window toolbar.
| @@ -214,7 +224,6 @@ void RManager::setUpMenu() | |||
| m_appMenu = m_mainWindow->menuBar()->addMenu(QString("App")); | |||
|
|
|||
| this->addApplication(QString("sample_mesh")); | |||
| this->addApplication(QString("euler1d")); | |||
There was a problem hiding this comment.
Since we have Euler in toolbar therefore removing euler1d from App.
yungyuc
approved these changes
Apr 12, 2024
Comment on lines
+134
to
+143
| m_eulerMenu = m_mainWindow->menuBar()->addMenu(QString("Euler")); | ||
|
|
||
| { | ||
| auto app_name = QString("euler1d"); | ||
| auto * action = new RAppAction( | ||
| QString("Load ") + app_name, | ||
| QString("Load ") + app_name, | ||
| QString("modmesh.app.") + app_name); | ||
| m_eulerMenu->addAction(action); | ||
| } |
| @@ -214,7 +224,6 @@ void RManager::setUpMenu() | |||
| m_appMenu = m_mainWindow->menuBar()->addMenu(QString("App")); | |||
|
|
|||
| this->addApplication(QString("sample_mesh")); | |||
| this->addApplication(QString("euler1d")); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are included in this PR:
Eulerinto main window menubar and removeload euerl1dfromappmenubar.Plot:
