Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should not be unit in the vertical axis in the 1D Euler solver plot #281

Closed
yungyuc opened this issue Mar 3, 2024 · 5 comments
Closed
Assignees
Labels
onedim One-dimensional solver viewer Visualize stuff

Comments

@yungyuc
Copy link
Member

yungyuc commented Mar 3, 2024

The 1D Euler solver uses non-dimensional equations. There should not be units in the vertical axis. There should be only one vertical axis, too.

image
@yungyuc yungyuc added viewer Visualize stuff onedim One-dimensional solver labels Mar 3, 2024
@yungyuc
Copy link
Member Author

yungyuc commented Mar 3, 2024

@j8xixo12 Could you please help fix it or find someone to?

@j8xixo12
Copy link
Collaborator

j8xixo12 commented Mar 4, 2024

I’ll find someone to fix it.

Does only one vertical axis means that the 2 vertical axis on the right hand side need to be removed ?
But if plot only has one vertical axis, the data lines with larger numerical ranges overlay the ones with smaller numerical ranges, making the smaller range lines less visible.

@yungyuc
Copy link
Member Author

yungyuc commented Mar 4, 2024

I’ll find someone to fix it.

Does only one vertical axis means that the 2 vertical axis on the right hand side need to be removed ? But if plot only has one vertical axis, the data lines with larger numerical ranges overlay the ones with smaller numerical ranges, making the smaller range lines less visible.

Yes, no more than 1 vertical axis. Vertical plotting range should not change as the code runs.

To help view small value, zooming should be implement in the viewer.

@j8xixo12
Copy link
Collaborator

@yungyuc
This issue has been resolved by #308, I think it can be closed.
However, I integrated matplotlib navigation toolbar into modmesh instead of self-implement.
Should we create another issue specifically to mention that it should be self-implemented?

@yungyuc
Copy link
Member Author

yungyuc commented Apr 19, 2024

Thanks a lot, @j8xixo12 , let me close this one.

Yes, please create another issue for enhancing the navigation widgets by home-grown code. If you file it before the sprint, I will bring it there and find hands.

@yungyuc yungyuc closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onedim One-dimensional solver viewer Visualize stuff
Projects
None yet
Development

No branches or pull requests

2 participants