Update proxy wasm cpp sdk to work with envoy 1.16.x #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop running duplicate tests for Gloo in the Istio e2e suites
ilackarms
reviewed
Sep 22, 2020
| # see what's in the cluster if we failed | ||
| git diff | ||
| kubectl get all -A | ||
| kubectl get configmaps -A |
There was a problem hiding this comment.
nit: we should probably move this into a script for long term maintenance
There was a problem hiding this comment.
just a thought, i realize we have this elsewhere (and i'm not saying now is the ideal time to refactor)
There was a problem hiding this comment.
I agree, good call. Also in general I think we can do a bunch of cleanup on this GH Actions file to streamline it a bit. I'm thinking we can use the matrix approach we use elsewhere. I tried a few performance optimizations to get the build time down in this PR (as you might see from the commits) but most of them ended up maxing out the CPU of the kind cluster in the e2e test machines and ultimately being rolled back.
ilackarms
reviewed
Sep 22, 2020
ilackarms
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested against the latest Gloo 1.5.0-beta (master) updated to use an envoy based on this PR - https://github.com/solo-io/envoy-gloo/pull/83/files and confirmed it's working.
For code reviewing, most of the changes in the diff are from moving the
examplesfolder down a level into theclipackage.Things to look at when reviewing:
envoy-wasm.Fixes #177
Fixes #145