Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Istio 1.7 #145

Closed
Sodman opened this issue Aug 10, 2020 · 4 comments · Fixed by #178
Closed

Support for Istio 1.7 #145

Sodman opened this issue Aug 10, 2020 · 4 comments · Fixed by #178
Assignees
@Sodman
Labels
enhancement New feature or request

Comments

@Sodman
Copy link
Member

Sodman commented Aug 10, 2020

Add support to wasme for Istio 1.7. We need to be able to create (init) and deploy filters that work with Istio 1.7.

There were no breaking envoy-wasm ABI changes between Istio 1.5 and Istio 1.6, so we should test a 1.6 image against Istio 1.7 to see if it's backwards compatible.

  • If it is, we can simply add 1.7 to the same target as the existing 1.5 and 1.6. (See Support Istio 1.6 #144).

  • If it's not backwards compatible, we'll need to create a new ABI target for Istio 1.7.
@emayssat
Copy link

+1

@yuval-k
Copy link
Member

yuval-k commented Aug 25, 2020

asm script ABI was updated to support istio 1.7 in version 0.1.8

@JacksChoco
Copy link

+1

1 similar comment
@xujinguang
Copy link

+1

@Sodman Sodman self-assigned this Sep 17, 2020
@Sodman Sodman added the enhancement New feature or request label Sep 17, 2020
@Sodman Sodman mentioned this issue Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sodman Sodman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update proxy wasm cpp sdk to work with envoy 1.16.x solo-io/wasm
5 participants
@yuval-k @Sodman @emayssat @xujinguang @JacksChoco