Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot -- fully qualified resource names #189

Closed
wants to merge 11 commits into from
Closed

snapshot -- fully qualified resource names #189

wants to merge 11 commits into from

Conversation

joekelley
Copy link
Contributor

@joekelley joekelley commented Jan 4, 2021 •
edited
Loading

Done:

  • input snapshot
  • input reconciler
  • hybrid input reconciler
  • input snapshot manual builder

TODO:

  • output snapshot

BOT NOTES:
resolves #151

@solo-changelog-bot
Copy link

Issues linked to changelog:
#151

@joekelley joekelley marked this pull request as draft January 4, 2021 15:20
@joekelley
Copy link
Contributor Author

it works! see https://github.com/solo-io/gloo-mesh/pull/1226

@ashleywang1
Copy link
Contributor

What were the steps required to make the gloo-mesh PR / bump the skv2 version?

  1. go get github.com/solo-io/skv2@alias (or v0.18.0 once the release happens)
  2. Generate all the code?
  3. Rename all the kinds to gvk types?

@joekelley
Copy link
Contributor Author

@ashleywang1 correct!

@ashleywang1
Copy link
Contributor

ashleywang1 commented Jan 26, 2021 •
edited
Loading

This is the PR in gloo-fed once skv2 v0.18.0 comes out - it was a lot easier than I was expecting! https://github.com/solo-io/gloo-fed/pull/321

Edit: LGTM

harveyxia
harveyxia reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@harveyxia harveyxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @ilackarms did you want to review?

@joekelley joekelley closed this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harveyxia harveyxia harveyxia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshot resource disambiguation
3 participants
@joekelley @ashleywang1 @harveyxia