New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot resource disambiguation #151

Open

joekelley opened this issue Sep 30, 2020 · 0 comments

Contributor

joekelley commented Sep 30, 2020

If two resources have the same Kind but different GroupVerisons, there can be ambiguity in the snapshot interfaces. See this example in Service Mesh Hub, where SMH and App Mesh both provide CRDs called "Mesh": https://github.com/solo-io/service-mesh-hub/pull/938/files#r495074978.

Harvey's recommendations for handling this are to update generated snapshots with one or both of:

an optional name alias for resources in the snapshot
group snapshot resources under a named GVK interface

solo-changelog-bot bot mentioned this issue

snapshot -- fully qualified resource names #189

Closed

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment