-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest Solidus, Rails 7 and Ruby 3+ support #204
Draft
MrTin
wants to merge
14
commits into
solidusio:main
Choose a base branch
from
MrTin:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started work on getting this to work with Rails 7 and Ruby 3+ -- opening this PR for collaboration.
I'm not user of Solidus or this extension, I was just downloading to play around with it and then went into a rabbit hole of fixing whatever was broken -- good weekend challenge 😅
I got mutations and queries working and updating relevant pieces of the code to work. I am however still hitting a few errors with integration tests and I suspect that it might have to do with changes to Solidus and the errors are more so for the tests than actually broken functionality.
Happy to help out here and fix the remaining problems if I can get some guidance on the changes you like to see and what goes where.
Changes
config.cache_classes = false
in test.rbstatesRequired
totrue
for expectationsmount_engine
toinstall_generator.rb
TODO
libvips-dev
as circleci dependencyNote: with Rails 7.1
config.cache_classes
is changed toenable_reloading
(see commit)Errors coming from Solidus core(?)
Spree::PaymentMethod::BogusCreditCard
Factories?