Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for Ruby 3 & status of the gem #206

Closed
brettchalupa opened this issue Jun 9, 2023 · 2 comments
Closed

No support for Ruby 3 & status of the gem #206

brettchalupa opened this issue Jun 9, 2023 · 2 comments

Comments

@brettchalupa
Copy link

Hi there! I'm hoping to use this gem in a Solidus 3.4 app to add some additional API functionality. I'm really interested in evaluating it and using it, but it hasn't received any updates in 1.5 years. When I try to bundle in a Ruby 3.1 app, I get this error:

solidus_graphql_api was resolved to 0.2.0, which depends on
  Ruby (~> 2.5)

Is this gem actively maintained? If so, will you all accept patches to update the gem to support Ruby 3.x and some modern versions of the GQL dependencies? Happy to help contribute, but I just want to ensure it's welcomed effort.

Thanks!

@kennyadsl
Copy link
Member

Hey @brettchalupa, this gem is not actively maintained but we would consider merging any PR which could improve the current state of it. There's already something at #204, which it's still draft but could be a good starting point.

If you want to contribute, you can definitely count on me for guidance.

@brettchalupa
Copy link
Author

@kennyadsl sounds good! Thanks for the details. 👍 I got the gem working on Ruby 3, Rails 7, Solidus 3.x on a fork of the repo. I'll work on contributing that back upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants