Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sd-select default scrollbar #1769

Merged
merged 3 commits into from
Jan 15, 2025
Merged

fix: sd-select default scrollbar #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6284027
fix: sd-select default scrollbar
paulovareiro29 Jan 13, 2025
4dac26d
chore: changeset
paulovareiro29 Jan 13, 2025
d4f334a
Merge branch 'next' of github.com:solid-design-system/solid into fix/…
paulovareiro29 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-impalas-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@solid-design-system/docs': patch
---

Fix `sd-select` displaying the scrollbar by default, even when unecessary.
2 changes: 1 addition & 1 deletion packages/components/src/components/select/select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ export default class SdSelect extends SolidElement implements SolidFormControl {
aria-labelledby="label"
part="listbox"
class=${cx(
'bg-white px-2 py-3 relative border-primary overflow-y-scroll',
'bg-white px-2 py-3 relative border-primary overflow-y-auto',
this.open && 'shadow',
this.currentPlacement === 'bottom'
? 'border-r-2 border-b-2 border-l-2 rounded-br-default rounded-bl-default'
Expand Down
Loading