Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sd-select default scrollbar #1769

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

paulovareiro29
Copy link
Contributor

@paulovareiro29 paulovareiro29 commented Jan 13, 2025

Description:

Closes #1318

This PR addresses:

  • sd-select default scrollbar appearing by default, even when unecessary

Definition of Reviewable:

  • relevant tickets are linked

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 4dac26d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 13, 2025

🚀 Storybook has been deployed for branch fix_sd-select-default-scrollbar

Copy link
Contributor

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this ticket but want to note down 2 things:

  • a bug was reported during UI REVIEW: fix: 🤔 sd-select weired bevaviour found in choromatic tests
    #1770
  • since i only have apple devices I made a call with @paulovareiro29 so he could share his screen for me to see the changes. all looks good.

@mariohamann mariohamann removed their assignment Jan 14, 2025
@coraliefeil coraliefeil removed their assignment Jan 14, 2025
@MartaPintoTeixeira MartaPintoTeixeira removed their assignment Jan 15, 2025
@paulovareiro29 paulovareiro29 merged commit 49615f2 into next Jan 15, 2025
12 checks passed
@paulovareiro29 paulovareiro29 deleted the fix/sd-select-default-scrollbar branch January 15, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

fix: 🤔 Scrollbar appears by default in sd-select component
7 participants