Add coding guidelines #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognize pubkey as a noun meaning the public key of a keypair.
We'll avoid introducing three-letter terms to free up the namespace for three-letter acronyms. But recognize the term "sigverify", a verb, to verify a digital signature.
garious
requested review from
sakridge,
aeyakovenko,
mvines,
rajgokal,
CriesofCarrots,
carllin,
pgarg66 and
rob-solana
aeyakovenko
approved these changes
Aug 9, 2018
mvines
approved these changes
Aug 9, 2018
CriesofCarrots
approved these changes
Aug 9, 2018
| @@ -149,7 +149,7 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
| fn gen_n_pubkeys(seed: [u8; 32], n: i64) -> HashSet<PublicKey> { | |||
| fn gen_n_pubkeys(seed: [u8; 32], n: i64) -> HashSet<Pubkey> { | |||
There was a problem hiding this comment.
generate? We use gen_ a few ways, not all of our making. But we use generate_ too...
There was a problem hiding this comment.
@CriesofCarrots, I missed this comment. Yes, I can fix that up in a separate PR. I can also rename GenKeys to KeyGenerator while I'm in the neighborhood.
sakridge
approved these changes
Aug 9, 2018
pgarg66
approved these changes
Aug 9, 2018
rob-solana
approved these changes
Aug 9, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
Bumps [rollup](https://github.com/rollup/rollup) from 2.34.0 to 2.34.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.34.0...v2.34.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Apr 19, 2024
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Rust coding guidelines and update the codebase to reflect those guidelines.
I've asked all active contributors to review these guidelines. If you don't agree, please speak up! This only works when everyone's on board!
Noteworthy changes:
keypairandpubkeyas words.sigas a word.Fixes #803