Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CONTRIBUTING.md #803

Closed
garious opened this issue Jul 31, 2018 · 0 comments
Closed

Add a CONTRIBUTING.md #803

garious opened this issue Jul 31, 2018 · 0 comments
Assignees

Comments

@garious
Copy link
Contributor

garious commented Jul 31, 2018

Some naming inconsistencies creeping in:

  • What to name a RwLockReadGuard variable? my_type_r, my_type, mytype_r, mytype
  • What to name a KeyPair? keypair, alice, id, alice_keypair, alice_kp
  • What to name a PublicKey? pubkey, alice, alice_pk
  • What to name a Hash? hash, id
  • What to name a Mint? mint, alice
  • What to name a FullNode? node, leader, validator, leader_node, leader_full_node, leader_fullnode
  • How to name a function? <verb>_<subject>, <something>_<qualifier>, <noun>

Add a CONTRIBUTING.md to offer guidance.

@garious garious added this to the v0.8.0 milestone Jul 31, 2018
@garious garious self-assigned this Jul 31, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this issue Aug 29, 2021
tao-stones pushed a commit to tao-stones/solana that referenced this issue Apr 15, 2024
Current code is only allowing gossip pull requests with legacy
contact-info:
https://github.com/anza-xyz/agave/blob/8c5a33a81/gossip/src/cluster_info.rs#L1958-L1966

Working towards migrating to the new contact-info, the commit allows
gossip pull requests with both legacy and new contact-infos.
buffalojoec pushed a commit to buffalojoec/solana that referenced this issue Apr 16, 2024
Current code is only allowing gossip pull requests with legacy
contact-info:
https://github.com/anza-xyz/agave/blob/8c5a33a81/gossip/src/cluster_info.rs#L1958-L1966

Working towards migrating to the new contact-info, the commit allows
gossip pull requests with both legacy and new contact-infos.
lijunwangs pushed a commit to lijunwangs/solana that referenced this issue Apr 24, 2024
…olana-labs#803) (solana-labs#816)

allows gossip pull requests with new contact-info (solana-labs#803)

Current code is only allowing gossip pull requests with legacy
contact-info:
https://github.com/anza-xyz/agave/blob/8c5a33a81/gossip/src/cluster_info.rs#L1958-L1966

Working towards migrating to the new contact-info, the commit allows
gossip pull requests with both legacy and new contact-infos.

(cherry picked from commit 50f1028)

Co-authored-by: behzad nouri <[email protected]>
yihau pushed a commit that referenced this issue Apr 26, 2024
…803) (#816)

allows gossip pull requests with new contact-info (#803)

Current code is only allowing gossip pull requests with legacy
contact-info:
https://github.com/anza-xyz/agave/blob/8c5a33a81/gossip/src/cluster_info.rs#L1958-L1966

Working towards migrating to the new contact-info, the commit allows
gossip pull requests with both legacy and new contact-infos.

(cherry picked from commit 50f1028)

Co-authored-by: behzad nouri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant