This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Remove loop in ReplayStage #8493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8493 +/- ##
========================================
- Coverage 80.3% 80.3% -0.1%
========================================
Files 256 256
Lines 56481 56475 -6
========================================
- Hits 45361 45354 -7
- Misses 11120 11121 +1 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2020
(cherry picked from commit 5f766cd) # Conflicts: # core/src/replay_stage.rs
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2020
(cherry picked from commit 5f766cd) # Conflicts: # core/src/replay_stage.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ReplayStage unnecessarily loops through the
compute_stats,select_forklogicAdded here:
3776d3a#diff-5984b6b0429f857c13a2a362669ab37cR329
with the intention that a validator would vote on all ancestors of the heaviest bank. However, with the introduction of fork weights, the validator will always pick the tip of the fork anyways, skipping hte ancestors.
Summary of Changes
Remove the loop
Fixes #