deserialize using get_data_size(), which refers to blob.data()'s length, instead of using msg.meta.size, which refers to the entire blob's length #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using msg.meta.size, which refers to the entire blob's length fixes solana-labs#752
|
this implies that deserialize() ignores extra bytes passed to it, as we've been passing 64 extra bytes to this call to deserialize() for a while with few ill effects until we got close to blob_size for a replication... |
|
this bit of code dates back to my very first PR #397, the bug in question was copied from existing code to my code ;) |
|
the modification to the test catches the error mvines was seeing in validators |
rob-solana
force-pushed
the
fix-752
branch
3 times, most recently
from
d5c10c4
to
868baad
Compare
mvines
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #752