Towards validator recovery, 1-to-1 Entry to Blob #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Jun 21, 2018
src/ledger.rs
Outdated
| use std::mem::size_of; | ||
| use transaction::Transaction; | ||
|
|
||
| // a Block is a vector of Entries |
src/entry.rs
Outdated
| entry | ||
| } | ||
|
|
||
| /// Creates the next entries for given transactions, outputs | ||
| /// updates start_hash to id of last Entry, sets cur_hashes to 0 | ||
| pub fn from_transactions_mut( |
There was a problem hiding this comment.
Seems like this should be in ledger.rs, where Block is defined.
There was a problem hiding this comment.
agreed, refactoring
src/tvu.rs
Outdated
| while let Ok(msg) = r_reader.recv_timeout(timer) { | ||
| println!("msg #{}: {:?}", i, msg); |
There was a problem hiding this comment.
print before trace of the same msg?
There was a problem hiding this comment.
leftovers from debugging
|
Can you update the PR description to offer more context? |
rob-solana
force-pushed
the
issue-309
branch
2 times, most recently
from
baac1da
to
e0eca1b
Compare
|
incorporated the "Cleanup entry" PR as well as I could... will continue to clean this up tomorrow... |
garious
approved these changes
Jun 22, 2018
|
speed of serialization/deserialization on master: |
aeyakovenko
approved these changes
Jun 22, 2018
* limit the number of Tntries per Blob to at most one
* limit the number of Transactions per Entry such that an Entry will
always fit in a Blob
With a one-to-one map of Entries to Blobs, recovery of a validator
is a simple fast-forward from the end of the initial genesis.log
and tx-*.logs Entries.
TODO: initialize validators' blob index with initial # of Entries.
garious
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hoping this looks like a "ready" part one
feedback appreciated.
issue #309 part 1
always fit in a Blob
With a one-to-one map of Entries to Blobs, recovery of a validator
is a simple fast-forward from the end of the initial genesis.log
and tx-*.logs Entries.
TODO: initialize validators' blob index with initial # of Entries.