This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
remove cargo install from CI #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
May 2, 2019
danpaul000
approved these changes
May 2, 2019
rob-solana
changed the title
joncinque
pushed a commit
to joncinque/solana
that referenced
this pull request
Jan 9, 2025
* Setup PohRecorder earlier for unified scheduler
* Use BankWithScheduler in banking-bench for US
* Move BankingPacket{Batch,Receiver} to new crate
* Extract duplicate tpu bank handling code for US
* Call wait_for_completed_scheduler in banking simulator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cargo install on a CI box assumes that CARGO_HOME/bin is on the path, which is not necessarily so, and defeats the purpose of our docker images for CI tooling
Summary of Changes
remove cargo install of tools (just audit left, apparently)
depends on #4122 and #4128
Fixes #4113