Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

cargo install in docker-rust images in CI considered harmful #4113

Closed
rob-solana opened this issue May 2, 2019 · 0 comments · Fixed by #4123
Closed

cargo install in docker-rust images in CI considered harmful #4113

rob-solana opened this issue May 2, 2019 · 0 comments · Fixed by #4123

Comments

@rob-solana
Copy link
Contributor

rob-solana commented May 2, 2019

Problem

some of our CI does cargo install (e.g. cargo-audit) into an ephemeral CARGO_HOME, which we cache to speed CI up, but in fact may corrupt the build, or the CARGO_HOME of the user

Proposed Solution

move those cargo install commands into the docker-rust image

@rob-solana rob-solana changed the title cargo install in CI considered harmful cargo install in docker-rust images in CI considered harmful May 2, 2019
@mvines mvines added this to the Silver Strand v0.15.0 milestone May 2, 2019
brooksprumo added a commit to brooksprumo/solana that referenced this issue Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants