Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes cap_accounts_data_size_per_block feature #35381

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Feb 29, 2024

Problem

The cap_accounts_data_size_per_block feature cannot and will not ever be activated. The code has been removed, but before that, it would introduce potential non-determinism. For more information, please refer to #27029

Here's the original feature gate issue: #25517

Now all that remains is the feature itself, and can be safely removed.

PRs that removed code gated by this feature:

Summary of Changes

Remove the cap_accounts_data_size_per_block feature

Feature Gate Issue: #25517

@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label Feb 29, 2024
@brooksprumo brooksprumo self-assigned this Feb 29, 2024
@brooksprumo brooksprumo marked this pull request as ready for review February 29, 2024 21:04
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (e8c87e8) to head (8df42e3).

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35381     +/-   ##
=========================================
- Coverage    81.8%    81.7%   -0.1%     
=========================================
  Files         834      834             
  Lines      224815   224814      -1     
=========================================
- Hits       183919   183874     -45     
- Misses      40896    40940     +44     

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same request as on #35378 : please add to the PR description a link to the PR(s) that removed the code gated by this feature before merge.

Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ tyera's pr/issue linkage suggestions

@brooksprumo brooksprumo merged commit 3ec020f into solana-labs:master Mar 1, 2024
46 checks passed
@brooksprumo brooksprumo deleted the accounts-data-size/remove-cap-block branch March 1, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants