Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: Cap Accounts Data Allocations Per Block #25517

Closed
6 of 7 tasks
brooksprumo opened this issue May 24, 2022 · 2 comments
Closed
6 of 7 tasks

Feature Gate: Cap Accounts Data Allocations Per Block #25517

brooksprumo opened this issue May 24, 2022 · 2 comments
Assignees
@brooksprumo
Labels
enhancement New feature or request feature-gate Pull Request adds or modifies a runtime feature gate work in progress This isn't quite right yet

Comments

@brooksprumo
Copy link
Contributor

brooksprumo commented May 24, 2022 •
edited
Loading

Description

🚧 Not scheduled for activation as implementation is incomplete 🚧

The maximum accounts data allocations per block is only enforced during BankingStage. A feature-gate is needed to enforce this check at ReplayStage as well.

Tasks to Complete Before Activation

Alternatives

Version Introduced

v1.11.?? (not introduced yet)

Feature ID

qywiJyZmqTKspFg2LeuUHqcA5nNvBgobqb9UprywS9N

Activation Method

Single Core Contributor

Testnet Activation Epoch

No response

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response
@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label May 24, 2022
@brooksprumo brooksprumo self-assigned this May 24, 2022
@brooksprumo brooksprumo mentioned this issue May 24, 2022
Merged
@brooksprumo brooksprumo modified the milestones: v1.11.0, v1.10.22 Jun 1, 2022
@brooksprumo brooksprumo added the enhancement New feature or request label Jun 16, 2022
@jstarry
Copy link
Member

jstarry commented Jul 6, 2022 •
edited
Loading

It looks like the current implementation has an issue, can we discuss in #26439 before activating?

@brooksprumo brooksprumo mentioned this issue Jul 6, 2022
Closed
@brooksprumo brooksprumo changed the title Feature Gate: Cap Accounts Data Size Per Block Feature Gate: Cap Per Block Accounts Data Size Jul 6, 2022
@brooksprumo brooksprumo mentioned this issue Aug 8, 2022
Closed
3 tasks
@brooksprumo brooksprumo mentioned this issue Aug 26, 2022
Closed
2 tasks
@brooksprumo brooksprumo changed the title Feature Gate: Cap Per Block Accounts Data Size Feature Gate: Cap Accounts Data Allocations Per Block Aug 26, 2022
@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Jan 9, 2023
@tao-stones tao-stones mentioned this issue Feb 8, 2023
Closed
@brooksprumo
Copy link
Contributor Author

Closing this issue as it cannot be implemented. It would introduce potential non-determinism. For more information, please refer to #27029

@brooksprumo brooksprumo closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
@brooksprumo brooksprumo mentioned this issue Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brooksprumo brooksprumo

Labels
enhancement New feature or request feature-gate Pull Request adds or modifies a runtime feature gate work in progress This isn't quite right yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brooksprumo @jstarry