blockstore: make merkle root Optional in MerkleRootMeta column #34091
Conversation
|
We good with leaving the |
We can probably rip it out after legacy shreds are fully gone, depending on how much of a PITA it is to migrate the column. |
Gotcha - my question was aimed at whether we should try to be proactive and put something like an enum in place to allow dual-support. But, the enum would be as much (if not more) hassle in matching enum type than always dealing with the |
…#34028) * add merkle root meta column to blockstore (#33979) * add merkle root meta column to blockstore * pr feedback: remove write/reads to column * pr feedback: u64 -> u32 + revert * pr feedback: fec_set_index u32, use Self::Index * pr feedback: key size 16 -> 12 (cherry picked from commit e457c02) * blockstore: make merkle root Optional in MerkleRootMeta column (#34091) --------- Co-authored-by: Ashwin Sekar <[email protected]>
…#34665) * add merkle root meta column to blockstore (#33979) * add merkle root meta column to blockstore * pr feedback: remove write/reads to column * pr feedback: u64 -> u32 + revert * pr feedback: fec_set_index u32, use Self::Index * pr feedback: key size 16 -> 12 (cherry picked from commit e457c02) # Conflicts: # ledger/src/blockstore.rs * fix conflicts * blockstore: make merkle root Optional in MerkleRootMeta column (#34091) --------- Co-authored-by: Ashwin Sekar <[email protected]>
Problem
After discussion, it seems like legacy shreds should be supported for a while longer. To avoid having to use
unwrap_or_default()and mess around withHash::default(), we change the type of the yet to be used column to optional.Summary of Changes
Change type. This will be backported to the same branches as #33979
Contributes to #33644