Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend duplicate proofs for merkle shreds #33644

Closed
AshwinSekar opened this issue Oct 11, 2023 · 0 comments · Fixed by #34270
Closed

Extend duplicate proofs for merkle shreds #33644

AshwinSekar opened this issue Oct 11, 2023 · 0 comments · Fixed by #34270
Assignees
@AshwinSekar

Comments

@AshwinSekar
Copy link
Contributor

AshwinSekar commented Oct 11, 2023 •
edited
Loading

Problem

We only construct duplicate proofs for conflicting shreds, LAST_SHRED_IN_SLOT, and erasure meta conflicts.

Proposed Solution

Extend this to include conflicting merkle roots.
@AshwinSekar AshwinSekar self-assigned this Oct 11, 2023
This was referenced Oct 21, 2023
Closed
Closed
@AshwinSekar AshwinSekar moved this from Todo to In Development in Duplicate block prevention and resolution Oct 27, 2023
@AshwinSekar AshwinSekar mentioned this issue Oct 27, 2023
Closed
This was referenced Nov 7, 2023
Merged
Merged
This was referenced Nov 15, 2023
Merged
Merged
Merged
@AshwinSekar AshwinSekar mentioned this issue Nov 29, 2023
Merged
@AshwinSekar AshwinSekar moved this from In Development to Code Review in Duplicate block prevention and resolution Nov 29, 2023
This was referenced Nov 30, 2023
Merged
Merged
@AshwinSekar AshwinSekar mentioned this issue Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshwinSekar AshwinSekar

Labels
None yet
Projects
Duplicate block prevention and resolution
Status: Done
Milestone
No milestone
1 participant
@AshwinSekar