ci: run test-stable-sbf in docker #33943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
force-pushed
the
run-sbf-test-in-docker
branch
from
8e32d26
to
ab2c24b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #33943 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 812 812
Lines 219730 219730
=========================================
- Hits 179989 179978 -11
- Misses 39741 39752 +11 |
t-nelson
reviewed
Nov 15, 2023
ci/buildkite-solana-private.sh
Outdated
| @@ -168,7 +168,7 @@ all_test_steps() { | |||
| ^sdk/ \ | |||
| ; then | |||
| cat >> "$output_file" <<"EOF" | |||
| - command: "ci/test-stable-sbf.sh" | |||
| - command: ". ci/rust-version.sh; ci/docker-run.sh $$rust_stable_docker_image ci/test-wasm.sh" | |||
There was a problem hiding this comment.
is it intentional to switch the test from stable-sbf to wasm here?
yihau
force-pushed
the
run-sbf-test-in-docker
branch
from
ab2c24b
to
000fd7f
Compare
t-nelson
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
a following PR for #33815
Summary of Changes
run test-stable-sbf in docker