ci: reorg docker images #33815
Merged
ci: reorg docker images #33815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems that it doesn't 🤔 I saw a pipeline success without this changes but with the latest images. |
t-nelson
previously approved these changes
Oct 23, 2023
Comment on lines
-42
to
-47
| # HACK: These are in our docker images, need to be removed from CARGO_HOME | ||
| # because we try to cache downloads across builds with CARGO_HOME | ||
| # cargo lacks a facility for "system" tooling, always tries CARGO_HOME first | ||
| cargo uninstall cargo-audit &>/dev/null || true | ||
| cargo uninstall svgbob_cli &>/dev/null || true | ||
| cargo uninstall mdbook &>/dev/null || true |
Codecov Report
@@ Coverage Diff @@
## master #33815 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 807 807
Lines 217406 218026 +620
=========================================
+ Hits 178043 178524 +481
- Misses 39363 39502 +139 |
oh yeah! I think it's a good idea. If we have those scripts, we can simply copy and run them when building the Docker image. btw, I'm considering moving all tests to Docker. That way, maybe no one will need to set up their CI machines; they'll just need to install Docker 😈 |
t-nelson
approved these changes
Oct 25, 2023
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we mount home directory and cargo directory when we run docker. actually we can just install those dependencies into our docker image.
Summary of Changes
build our Docker images on Ubuntu.
(will upload these images when I get approve. I have already test them and all green 🤞 but I will still run them with our ci agents again to ensure everything is fine)