Stops pushing legacy snapshot hashes to crds #33576
Conversation
brooksprumo
added
noCI
brooksprumo
added
CI
| self.cluster_info | ||
| .push_legacy_snapshot_hashes(clone_hashes_for_crds( | ||
| self.legacy_full_snapshot_hashes.as_slice(), | ||
| )); |
There was a problem hiding this comment.
This is the main change. Because we remove this call, then all the other code removals fall out from here.
|
What happens if a node running legacy v1.14 tries to query the legacy snapshot hash? |
If the majority of nodes on the cluster are running v1.16 or older, the v1.14 node will bootstrap without issue. This is mnb today. If the cluster has already enabled v1.16 feature gates, then a v1.14 node cannot join the network at all, so its bootstrap process is moot. This is testnet today. This PR will only be backported to v1.17, and v1.16 is compatible with it. So testnet is fine. If someone runs v1.17+ on mnb, it shouldn't impact a v1.14 node. This is because (1) the v1.17 node is unlikely to be listed as one of the v1.14 node's known validators, and (2), almost all the nodes on mnb are v1.16, since v1.17 is not recommended for mnb. (And soon mnb's floor will raise to v1.16 due to feature gate activations, rendering v1.14 moot there as well.) |
(cherry picked from commit c588f25)
(cherry picked from commit c588f25)
solana-labs#33576 stops broadcasting legacy snapshot hashes over gossip, and the commit removes unused legacy snapshot hashed code in gossip.
solana-labs#33576 stops broadcasting legacy snapshot hashes over gossip, and this commit removes unused legacy snapshot hashed code in gossip.
#33576 stops broadcasting legacy snapshot hashes over gossip, and this commit removes unused legacy snapshot hashed code in gossip.
…) (#33581) (cherry picked from commit c588f25) Co-authored-by: Brooks <[email protected]>
Problem
Now that the clusters are on v1.16 (or later), we no longer query
LegacySnapshotHashesduring bootstrap to discover snapshots to download (as of #31275). This means we can also stop pushing that information to CRDS.Summary of Changes
Stop pushing legacy snapshot hashes.
Fixes #31282
Note, this PR purposely does not remove anything from CRDS itself. That will be handled in subsequent PRs.