Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop pushing to LegacySnapshotHashes #31282

Closed
brooksprumo opened this issue Apr 20, 2023 · 0 comments · Fixed by #33576
Closed

Stop pushing to LegacySnapshotHashes #31282

brooksprumo opened this issue Apr 20, 2023 · 0 comments · Fixed by #33576
Assignees
@brooksprumo

Comments

@brooksprumo
Copy link
Contributor

brooksprumo commented Apr 20, 2023 •
edited
Loading

Now that bootstrap only uses SnapshotHashes for snapshot discovery, we no longer need to push to LegacySnapshotHashes inside of SnapshotGossipManager.

However

We must wait until the cluster has upgraded—to v1.16 or later1—first.

Once that happens, we can stop pushing to LegacySnapshotHashes, and maybe even remove it from CRDS!

Footnotes

  1. Or really whatever version is the first to include https://github.com/solana-labs/solana/pull/31275 ↩
@brooksprumo brooksprumo converted this from a draft issue Apr 20, 2023
@brooksprumo brooksprumo self-assigned this Apr 20, 2023
@brooksprumo brooksprumo changed the title Stop pushing to LegacySnapshotHashes in SnapshotGossipManager Stop pushing to LegacySnapshotHashes Apr 20, 2023
@brooksprumo brooksprumo mentioned this issue Oct 7, 2023
Merged
@brooksprumo brooksprumo moved this from Todo to In Progress in Better Snapshot Bootstrap (BSB) Oct 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Better Snapshot Bootstrap (BSB) Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
No open projects
Better Snapshot Bootstrap (BSB)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stops pushing legacy snapshot hashes to crds brooksprumo/solana
1 participant
@brooksprumo