Add stake_flags to stake state

[HaoranYi]

Problem

Fix a stake redelegation issue.

Part of #31876

Summary of Changes

Add StakeFlags to StakeState

NOTE: This change just adds StakeFlags to StakeState. The Stake behavior should not change.
The actual fix will come in a following PR once this PR is merged.

Fixes #

[HaoranYi]

This PR will break downstream spl repo.

Here is the following up PR to fix SPL repo, once this PR is merged:
solana-labs/solana-program-library#4504

[t-nelson]

lgtm. gonna give spl folks the final approval here though since you'll need to workout deployment strategy with them

[mvines]

We probably should bump the major version of the solana-program crate with this PR (once releng folks figure out how to do this!) since it's a breaking change

[HaoranYi]

We probably should bump the major version of the solana-program crate with this PR (once releng folks figure out how to do this!) since it's a breaking change

I am not familiar with the version of solana-program. Do you mean to bump the following version?

./stake-pool/program/Cargo.toml:version = "0.7.0"

@joncinque

[t-nelson]

I am not familiar with the version of solana-program. Do you mean to bump the following version?

./stake-pool/program/Cargo.toml:version = "0.7.0"

no. the version field in sdk/program/Cargo.toml (monorepo). there's an initiate to move both this crate and solana-sdk out of the monorepo, so they can be more easily independently versioned

[HaoranYi]

diff --git a/ci/downstream-projects/func-spl.sh b/ci/downstream-projects/func-spl.sh
index 2eaf9baae3..d525e04949 100755
--- a/ci/downstream-projects/func-spl.sh
+++ b/ci/downstream-projects/func-spl.sh
@@ -20,10 +20,14 @@ spl() {
     )
     set -x
     rm -rf spl
-    git clone https://github.com/solana-labs/solana-program-library.git spl
+    git clone https://github.com/HaoranYi/solana-program-library.git spl
     # copy toolchain file to use solana's rust version
     cp "$SOLANA_DIR"/rust-toolchain.toml spl/
     cd spl || exit 1
+   git checkout redelegation_fix

     project_used_solana_version=$(sed -nE 's/solana-sdk = \"[>=<~]*(.*)\"/\1/p' <"token/program/Cargo.toml")
     echo "used solana version: $project_used_solana_version"

I have manually built and tested spl PR together with this change. All tests passed.

[t-nelson]

I have manually built and tested spl PR together with this change. All tests passed.

less concerned about the tests and more about what needs to happen to get the program redeployed with this patch

[joncinque]

less concerned about the tests and more about what needs to happen to get the program redeployed with this patch

The current deserializers work properly with the change, so we don't actually need to update the program. They just ignore the new stuff at the end of the struct

[t-nelson]

less concerned about the tests and more about what needs to happen to get the program redeployed with this patch

The current deserializers work properly with the change, so we don't actually need to update the program. They just ignore the new stuff at the end of the struct

put yer money where yer mouth is and approve? 😉

[2501babe]

im assuming the intent of flags (if more flags are ever added) is only for transient internal state tracking, so doesnt need to show up in UiStakeAccount?

[t-nelson]

i don't think we need to impose any use-restrictions on the flags. future additions that make sense to display will likely need handling that we can't predict today. for instance i'll claim one when i get around proposing vote account bonds, but ui display would probably be something like

flags.contains(FLAG_VOTER_BOND).then_some(delegation.vote_account)

[HaoranYi]

#32033

^^ This is a follow up PR, which adds the stake flags to UiStakeAccount.

[2501babe]

lgtm, also note i tested my single pool cli tests, with a cli built against this pr, and a program built against 1.16, and everything worked fine. i wasnt able to run any sbf tests for an issue unrelated to this pr (ie they fail on monorepo master too, i think because of the tokio upgrade)

i am curious what the upgrade story here is tho, will you cut a new monorepo release after this pr? or is this blocked on splitting sdk/program out of monorepo? since once this is merged, we would need something to update to, and in the mean time monorepo ci will break on the downstream projects tests

[HaoranYi]

Merged.
solana-labs/solana-program-library#4504 was also merged.

[joncinque]

Late review, but just wanted to say that the stake program changes look good!