stake-pool: Update tests for 1.17 #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
reviewed
Aug 6, 2023
Comment on lines
2382
to
2386
| let mut data = bincode::serialize::<stake::state::StakeState>( | ||
| &stake::state::StakeState::Stake(meta, stake), | ||
| ) | ||
| .unwrap(); | ||
| data.extend_from_slice(&[0, 0, 0, 0]); |
There was a problem hiding this comment.
i havent run the code to see what happens but shouldnt this have a check that the length is 196 before extending? otherwise when we move to 1.17 we would extend to 204
There was a problem hiding this comment.
good point, I'll instead allocate a bigger vec and then write into it
2501babe
previously approved these changes
Aug 6, 2023
|
otherwise lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SPL downstream tests were disabled in solana-labs/solana#32524, but we need to re-enable the downstream tests to avoid breaking people in the future, per solana-labs/solana#32655.
After doing the work to reinstate the old
StakeStateand re-enabling the downstream tests, there were errors in the stake pools tests.Solution
The biggest change relates to the async rewards payout being implemented for solana-foundation/solana-improvement-documents#15 -- we have to warp to
slot + 1in order to get out of the rewards payout time.After that, there was one issue where we weren't serializing 200 bytes for stake accounts in a test.
And a little extra thing, I noticed that
retainin the stake pool program was using a function pointer instead of a closure, so I changed to be a closure, same as all the otherbig_vecfunctions. This should improve compute-unit performance because the Rust compiler can inline closures, but not calling into function pointers.