Bump and unpin tokio #32430
Merged
Bump and unpin tokio #32430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
bump-tokio
branch
from
495f2fc to
45dba58
Compare
Codecov Report
@@ Coverage Diff @@
## master #32430 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 778 778
Lines 210199 210206 +7
=======================================
+ Hits 172616 172662 +46
+ Misses 37583 37544 -39 |
CriesofCarrots
force-pushed
the
bump-tokio
branch
from
45dba58 to
42d6f03
Compare
behzadnouri
approved these changes
Jul 13, 2023
CriesofCarrots
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
|
praise be to jesus thank you |
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
Aug 20, 2023
* Bump tokio to current, and unpin * Remove patch since ntapi is not longer in tree (cherry picked from commit c020211)
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
Aug 20, 2023
* Bump tokio to current, and unpin * Remove patch since ntapi is not longer in tree (cherry picked from commit c020211)
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
Aug 20, 2023
* Bump tokio to current, and unpin * Remove patch since ntapi is not longer in tree (cherry picked from commit c020211)
|
This needs to be backported to v1.16: #32909 |
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
Aug 20, 2023
* Bump tokio to current, and unpin * Remove patch since ntapi is not longer in tree (cherry picked from commit c020211)
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
Aug 28, 2023
* Bump tokio to current, and unpin * Remove patch since ntapi is not longer in tree (cherry picked from commit c020211)
buffalu
pushed a commit
to buffalu/solana
that referenced
this pull request
Aug 29, 2023
* Bump tokio to current, and unpin * Remove patch since ntapi is not longer in tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We pinned tokio to v1.14.1 because later versions (with this commit tokio-rs/tokio@4eed411) were causing significant stalling problems for RPC operators (#24644). However, this is no longer the case for current versions of tokio on solana edge channel. Meanwhile, the old tokio version causes trouble for core eng working on quic as well as on-chain program developers downstream.
Summary of Changes
Bump tokio
Remove ntapi since it is no longer in the tree
Fixes #24644
Fixes #29586