Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solana-client v.1.16 depends on pinned tokio version (~1.14.1) compared to solana-client v.1.14 (tokio ^1) #32878

Closed
andreisilviudragnea opened this issue Aug 18, 2023 · 3 comments
Closed

solana-client v.1.16 depends on pinned tokio version (~1.14.1) compared to solana-client v.1.14 (tokio ^1) #32878

andreisilviudragnea opened this issue Aug 18, 2023 · 3 comments
Labels
community Community contribution

Comments

@andreisilviudragnea
Copy link

andreisilviudragnea commented Aug 18, 2023 •
edited
Loading

Problem

Using solana-client v1.16.8 forces the clients of this crate to downgrade tokio to a version more than a year old. This problem has been introduced by #29893, when the tokio version specified for solana-client changed from ^1 to ~1.14.1.

Fixed by #33058.
@andreisilviudragnea andreisilviudragnea added the community Community contribution label Aug 18, 2023
andreisilviudragnea added a commit to andreisilviudragnea/solana that referenced this issue Aug 18, 2023
@andreisilviudragnea
Fix solana-labs#32878
f091f84
@andreisilviudragnea andreisilviudragnea mentioned this issue Aug 18, 2023
Closed
andreisilviudragnea added a commit to andreisilviudragnea/solana that referenced this issue Aug 18, 2023
@andreisilviudragnea
Fix solana-labs#32878
932727d
@andreisilviudragnea andreisilviudragnea mentioned this issue Aug 20, 2023
Closed
@andreisilviudragnea andreisilviudragnea changed the title solana-client v.1.16.8 depends on older tokio version (~1.14.1) compared to solana-client v.1.14.20 (tokio ^1) solana-client v.1.16 depends on fixed tokio version (~1.14.1) compared to solana-client v.1.14 (tokio ^1) Aug 20, 2023
@andreisilviudragnea andreisilviudragnea changed the title solana-client v.1.16 depends on fixed tokio version (~1.14.1) compared to solana-client v.1.14 (tokio ^1) solana-client v.1.16 depends on pinned tokio version (~1.14.1) compared to solana-client v.1.14 (tokio ^1) Aug 20, 2023
@andreisilviudragnea andreisilviudragnea mentioned this issue Aug 22, 2023
Closed
afalaleev added a commit to afalaleev/solana that referenced this issue Aug 22, 2023
@afalaleev
Fix solana-labs#32878
5524187
@afalaleev afalaleev mentioned this issue Aug 22, 2023
Closed
@andreisilviudragnea andreisilviudragnea mentioned this issue Aug 23, 2023
Closed
@buffalu
Copy link
Contributor

buffalu commented Aug 29, 2023

YES PLZ

@mvines
Copy link
Member

mvines commented Aug 29, 2023

solana-storage-bigtable is another v1.16 crate that could use this same treatment

@andreisilviudragnea
Copy link
Author

It should be fixed by #33058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #32878 andreisilviudragnea/solana
3 participants
@mvines @andreisilviudragnea @buffalu