Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageStage now sends transactions at the local TPU #3195

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

mvines
Copy link
Member

@mvines mvines commented Mar 8, 2019

The local TPU will forward the transactions as needed if it's not currently the leader.

This reduces the complexity of:

  • the storagestage, it doesn't need to care who the leader is t
  • reduces the users of gossip's notion of a leader (progress towards Remove CrdsValue::LeaderId #3188)

cc: #3193

@mvines mvines requested a review from sakridge March 8, 2019 18:39
exit: &Arc<AtomicBool>,
keypair: &Arc<Keypair>,
account_to_create: Option<Pubkey>,
) -> io::Result<()> {
if let Some(leader_info) = cluster_info.read().unwrap().leader_data() {
let mut client = mk_client_with_timeout(leader_info, Duration::from_secs(5));
let node_info = cluster_info.read().unwrap().my_data();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/leader_data/my_data/ on this line is really the only functional change in this PR.

The rest of the patch is just code shifting around and my desire to purge the codebase of "tx" (like does this mean "transaction" or "transmit"...we use "tx" for both!)

Copy link
Member

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #3195 into master will increase coverage by <.1%.
The diff coverage is 42.8%.

@@           Coverage Diff            @@
##           master   #3195     +/-   ##
========================================
+ Coverage    81.1%   81.2%   +<.1%     
========================================
  Files         129     129             
  Lines       19614   19614             
========================================
+ Hits        15918   15934     +16     
+ Misses       3696    3680     -16

1 similar comment
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #3195 into master will increase coverage by <.1%.
The diff coverage is 42.8%.

@@           Coverage Diff            @@
##           master   #3195     +/-   ##
========================================
+ Coverage    81.1%   81.2%   +<.1%     
========================================
  Files         129     129             
  Lines       19614   19614             
========================================
+ Hits        15918   15934     +16     
+ Misses       3696    3680     -16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants