Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC now sends transactions at the local TPU #3193

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Conversation

mvines
Copy link
Member

@mvines mvines commented Mar 8, 2019

The local TPU will forward the transactions as needed if it's not currently the leader.

This reduces the complexity of:

  • the RPC subsystem, it doesn't need to follow the leader around.
  • reduces the users of gossip's notion of a leader (progress towards Remove CrdsValue::LeaderId #3188)

mvines added 2 commits March 8, 2019 09:57
The local TPU will forward the transactions as needed if it's not
currently the leader
@mvines mvines requested a review from CriesofCarrots March 8, 2019 18:01
@mvines mvines added work in progress This isn't quite right yet and removed work in progress This isn't quite right yet labels Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #3193 into master will decrease coverage by <.1%.
The diff coverage is 77.7%.

@@           Coverage Diff            @@
##           master   #3193     +/-   ##
========================================
- Coverage    81.1%   81.1%   -0.1%     
========================================
  Files         129     129             
  Lines       19614   19601     -13     
========================================
- Hits        15918   15905     -13     
  Misses       3696    3696

@mvines
Copy link
Member Author

mvines commented Mar 8, 2019

Merging #3193 into master will decrease coverage by <.1%.

Yeah that makes no sense!

@CriesofCarrots
Copy link
Contributor

Merging #3193 into master will decrease coverage by <.1%.

Yeah that makes no sense!

The CodeCov numbers seem a bit flaky to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants