[zk-token-sdk] Refactor zk-token-elgamal conversion code for authenticated encryption, range proof, and sigma proof types
#31855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31855 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 752 752
Lines 206799 206751 -48
=========================================
- Hits 169480 169398 -82
- Misses 37319 37353 +34 |
|
|
||
| /// Serialization of range proofs for 64-bit numbers (for `Withdraw` instruction) | ||
| /// The `RangeProof` type as a `Pod` restricted to proofs on 64-bit numbers. | ||
| #[derive(Clone, Copy)] | ||
| #[repr(transparent)] | ||
| pub struct RangeProof64(pub [u8; 672]); |
There was a problem hiding this comment.
If it's not too late, could we rename these to ...U64 to match the instructions and other types? (different PR)
There was a problem hiding this comment.
Yes, I was going to do that. I don't think SPL or any of the dependencies use range proof types directly, so I think it should be okay.
CriesofCarrots
approved these changes
May 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 30, 2023
…ticated encryption, range proof, and sigma proof types (#31855) * refactor convert logic for `AeCiphertext` * refactor convert logic for `RangeProof` * refactor convert logic for sigma proof types * Apply suggestions from code review Co-authored-by: Tyera <[email protected]> --------- Co-authored-by: Tyera <[email protected]> (cherry picked from commit e4fe933)
samkim-crypto
added a commit
that referenced
this pull request
May 31, 2023
… authenticated encryption, range proof, and sigma proof types (backport of #31855) (#31887) [zk-token-sdk] Refactor `zk-token-elgamal` conversion code for authenticated encryption, range proof, and sigma proof types (#31855) * refactor convert logic for `AeCiphertext` * refactor convert logic for `RangeProof` * refactor convert logic for sigma proof types * Apply suggestions from code review Co-authored-by: Tyera <[email protected]> --------- Co-authored-by: Tyera <[email protected]> (cherry picked from commit e4fe933) Co-authored-by: samkim-crypto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a follow-up to #31846 on refactoring conversion logic in
convert.rs(#31813).Summary of Changes
TryandTryFromimplementation for authenticated encryption type tozk_token_elgamal::auth_encryptionTryandTryFromimplementation for range proof types tozk_token_elgamal::range_proofTryandTryFromimplementation for sigma proof types tozk_token_elgamal::sigma_proofsFixes #