Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-token-sdk] clean-up zk-token-elgamal submodule in zk-token-sdk #31813

Closed
samkim-crypto opened this issue May 25, 2023 · 0 comments
Closed
Labels
stale [bot only] Added to stale content; results in auto-close after a week.

Comments

@samkim-crypto
Copy link
Contributor

samkim-crypto commented May 25, 2023

Problem

The zk-token-elgamal submodule contains pod types for various types in zk-token-sdk. Currently, the code in this submodule is quite messy, docs are missing, and overall quite hard to read. Cleaning up zk-token-elgamal is long overdue.

Proposed Solution

Clean up zk-token-elgamal in a series of steps:

  • refactor the pod types that live in zk-token-elgamal/pod into separate submodules
  • refactor the conversion logic in convert into separate submodules that were created in the previous step
  • refactor decrypt.rs and ops.rs into a single submodule
  • clean-up and add documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

1 participant