This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
[zk-token-sdk] Refactor zk-token-elgamal pod types
#31814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31814 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 738 744 +6
Lines 205902 205902
=========================================
- Hits 168705 168644 -61
- Misses 37197 37258 +61 |
Co-authored-by: Tyera <[email protected]>
CriesofCarrots
approved these changes
May 26, 2023
| }; | ||
| pub use { | ||
| auth_encryption::AeCiphertext, | ||
| bytemuck::{Pod, Zeroable}, |
There was a problem hiding this comment.
Incidentally, why do we re-export these traits?
There was a problem hiding this comment.
The bytemuck version on the monorepo and spl side do not always match, so I had some issues before without re-exporting these traits. I can't seem to reproduce it or recall what the precise issue was right now though ... 😕
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
zk-token-elgamalsubmodule contains pod types for various types inzk-token-sdk. Currently, all pod types live in the singlepod.rs, which could be broken into separate submodules.Summary of Changes
Break up the pod types into separate submodules within
zk-token-elgamal.This addresses step 1 of #31813,
Fixes #