-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain use of nightly clippy over whole monorepo #31833
Conversation
@@ -77,7 +77,12 @@ _ ci/order-crates-for-publishing.py | |||
|
|||
nightly_clippy_allows=(--allow=clippy::redundant_clone) | |||
|
|||
# run nightly clippy for `sdk/` as there's a moderate amount of nightly-only code there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ./sdk
reference was arguably stale
as a matter of fact, this particular line is added at #8012 (comment) but frozen abi is moved out of ./sdk
at #13008
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if my comment/suggestions don't show up properly. You pushed while I was reviewing and I'm too lazy to recreate them 😝
ci/test-checks.sh
Outdated
# use nightly clippy as frozen-abi proc-macro generates a lot of code across | ||
# various crates in this whole mono-repo. Likewise, frozen-abi(-macro) crates' | ||
# unit tests are only compiled under nightly. | ||
# similarly nightly is desired to run clippy over all of bench files because | ||
# the bench itself isn't stabilized yet... | ||
# ref: https://github.com/rust-lang/rust/issues/66287 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# use nightly clippy as frozen-abi proc-macro generates a lot of code across | |
# various crates in this whole mono-repo. Likewise, frozen-abi(-macro) crates' | |
# unit tests are only compiled under nightly. | |
# similarly nightly is desired to run clippy over all of bench files because | |
# the bench itself isn't stabilized yet... | |
# ref: https://github.com/rust-lang/rust/issues/66287 | |
# Use nightly clippy, as frozen-abi proc-macro generates a lot of code across | |
# various crates in this whole monorepo. Likewise, frozen-abi(-macro) crates' | |
# unit tests are only compiled under nightly. | |
# Similarly, nightly is desired to run clippy over all of bench files because | |
# the bench itself isn't stabilized yet... | |
# ref: https://github.com/rust-lang/rust/issues/66287 |
Comment nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear from this comment why "frozen-abi proc-macro generating code" necessitates nightly clippy. Can you expand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe, nice question. how about this?: dda0127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe, nice question. how about this?: dda0127
Much better, thank you!
haha, what a expedited code reviewing service. thanks a lot :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Add proper and updated explanation as to nightly clippy (#31692 (review)):
... so that I can hide my real desire (hint: branch name) from public scrutiny. :)
ref: rust-lang/rust#66287