Skip to content

Commit

Permalink
Incorporate review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
ryoqun authored May 26, 2023
1 parent d28f2db commit dda0127
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions ci/test-checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,11 @@ _ ci/order-crates-for-publishing.py

nightly_clippy_allows=(--allow=clippy::redundant_clone)

# use nightly clippy as frozen-abi proc-macro generates a lot of code across
# various crates in this whole monorepo. Likewise, frozen-abi(-macro) crates'
# Use nightly clippy, as frozen-abi proc-macro generates a lot of code across
# various crates in this whole monorepo (frozen-abi is enabled only under nightly
# due to the use of unstable rust feature). Likewise, frozen-abi(-macro) crates'
# unit tests are only compiled under nightly.
# similarly nightly is desired to run clippy over all of bench files because
# Similarly, nightly is desired to run clippy over all of bench files because
# the bench itself isn't stabilized yet...
# ref: https://github.com/rust-lang/rust/issues/66287
_ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy --workspace --all-targets --features dummy-for-ci-check -- \
Expand Down

0 comments on commit dda0127

Please sign in to comment.