Do not overwrite builtin program in the same slot #31718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31718 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 737 736 -1
Lines 205992 205943 -49
=========================================
- Hits 168717 168676 -41
+ Misses 37275 37267 -8 |
Lichtso
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The builtin programs are allowed to be overwritten in the same slot as initial deployment.
Summary of Changes
The test added builtin as part of bank initialization. It was later adding an existing builtin in the same bank. This PR updates the test to create a child bank to overwrite the builtin. Also removes the special handling of overwriting the builtin in the same slot as the initial deployment.
Fixes #