Refactor - Merges BuiltinPrograms
into LoadedPrograms
#31654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Continuation of #31565.
Built-in programs should take the same paths through the program-runtime as user supplied programs do. This is an important step for their ongoing unification in program-runtime-v2.
Summary of Changes
genesis_builtins()
andbuiltin_feature_transitions()
with a static sliceBUILTINS
BuiltinFeatureTransition
withBuiltinPrototype
which has an optionalPubkey
for the activation feature, the valueNone
signals a built-in to be present at genesisbuiltins::create_builtin()
, useloaded_programs::LoadedProgram::new_builtin()
insteadBuiltinPrograms
,Bank::builtin_programs
andInvokeContext::builtin_programs
with_mock_invoke_context_and_builtin_programs!()
InvokeContext::programs_loaded_for_tx_batch
instead ofInvokeContext::builtin_programs
LoadedProgram::account_size
toname.len()
for built-inseffective_slot
anddeployment_slot
to the slot in which their feature was activated