Refactor - Simplify built-in program feature transition #31565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
changed the title
pgarg66
reviewed
May 9, 2023
Turns BuiltinFeatureTransition from an enum into a struct.
Lichtso
force-pushed
the
refactor/builtin_program_feature_transition
branch
from
4dfe809 to
bafb026
Compare
Codecov Report
@@ Coverage Diff @@
## master #31565 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 734 734
Lines 205278 205237 -41
=======================================
+ Hits 166926 166939 +13
+ Misses 38352 38298 -54 |
pgarg66
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is a preparation for unifying the logic which transitions built-in programs on epoch boundaries (in which their features are activated) and the bitemporal model of the
LoadedProgramscache (which utilizes an effective slot field per entry).Summary of Changes
builtins::get_builtins(), instead derives them fromBank::builtin_programs.BuiltinAction.BuiltinFeatureTransitionfrom an enum into a struct.Bank::remove_builtin()place tombstones.