Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: prefer clippy::default_trait_access over shell #31318

Merged
merged 1 commit into from
Apr 24, 2023
Merged

ci: prefer clippy::default_trait_access over shell #31318

merged 1 commit into from
Apr 24, 2023

Conversation

ryoqun
Copy link
Member

@ryoqun ryoqun commented Apr 23, 2023 •
edited
Loading

@ryoqun ryoqun mentioned this pull request Apr 23, 2023
Closed
@ryoqun ryoqun requested a review from mvines April 23, 2023 13:32
@ryoqun
Copy link
Member Author

ryoqun commented Apr 23, 2023

@ryoqun ryoqun requested a review from mvines now

Requesting reviewing in the courtesy of good service of #2711 :)

@ryoqun ryoqun changed the title Prefer clippy::default_trait_access over shell ci: prefer clippy::default_trait_access over shell Apr 23, 2023
mvines
mvines approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice

@ryoqun ryoqun merged commit cece64d into solana-labs:master Apr 24, 2023
@brooksprumo brooksprumo mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvines mvines mvines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default::default() makes code unreadable
2 participants
@ryoqun @mvines