Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default::default() makes code unreadable #2630

Closed
garious opened this issue Feb 1, 2019 · 1 comment · Fixed by #31318
Closed

Default::default() makes code unreadable #2630

garious opened this issue Feb 1, 2019 · 1 comment · Fixed by #31318
Labels
good first issue Good for newcomers
Milestone
v0.12.0 Beacons

Comments

@garious
Copy link
Contributor

garious commented Feb 1, 2019

Problem

Rust offers us this convenient feature of setting any type that implements Default to its default using Default::default(). Unfortunately it makes the code unreadable.

Proposed Solution

Replace most of the 72 instances in current code with an explicit type. For example, if the function accepts a Pubkey, replace Default::default() with Pubkey::default().
@garious garious added the good first issue Good for newcomers label Feb 1, 2019
@garious garious added this to the The Future! milestone Feb 1, 2019
@mvines mvines mentioned this issue Feb 9, 2019
Merged
@garious garious modified the milestones: The Future!, v0.12 Beacons Feb 13, 2019
@svenski123 svenski123 mentioned this issue Jun 15, 2020
Merged
@ryoqun
Copy link
Member

ryoqun commented Apr 23, 2023 •
edited
Loading

seems clippy now supports this natively: https://rust-lang.github.io/rust-clippy/v0.0.212/index.html#default_trait_access #31318

@ryoqun ryoqun mentioned this issue Apr 23, 2023
Merged
@brooksprumo brooksprumo mentioned this issue Sep 29, 2023
Merged
steviez pushed a commit to steviez/solana that referenced this issue Aug 20, 2024
@Lichtso
Adjustments of loader-v4 (solana-labs#2630)
acaf5b7 
- Removes the empty program account check (InvalidAccountData).
- Adjusts checks of program.state.status to conform to error messages.
- Adds check to prevent authority transfer to itself.
- Adjusts most execution errors to UnsupportedProgramId.
- Removes the redundant owner check in execution.
- Adds a tombstone in the program cache upon retraction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.12.0 Beacons
Development

Successfully merging a pull request may close this issue.

ci: prefer clippy::default_trait_access over shell ryoqun/solana
2 participants
@garious @ryoqun