validator: Move skip_poh_verify into the deprecated list

[ilya-bobyr]

Follow-up for

  commit 809041b1519ebaa54d6ffe4ce194f04feb8eda0f
  Author: Illia Bobyr <[email protected]>
  Date:   Wed Mar 22 11:03:30 2023 -0700

      poh_verify => run_verification: Rename to be more accurate (#30811)

      `poh_verify` actually disables transaction signature, tick count and
      built in program argument verifications as well.  It is somewhat
      confusing to call it `poh_verify`.

[steviez]

Thanks for jumping on this so quick. As for the help message of the now deprecated arg, you can leave it as is. Instead, add it to this list:

solana/validator/src/cli.rs

Line 1913 in 24be850

static ref DEPRECATED_ARGS_AND_HELP: Vec<(&'static str, &'static str)> = vec![

which will get iterated through and spit out uniform messages about deprecated args:

solana/validator/src/cli.rs

Lines 1718 to 1727 in 24be850

	pub fn warn_for_deprecated_arguments(matches: &ArgMatches) {
	for (arg, help) in DEPRECATED_ARGS_AND_HELP.iter() {
	if matches.is_present(arg) {
	warn!(
	"{}",
	format!("--{arg} is deprecated. {help}").replace('_', "-")
	);
	}
	}
	}

which means you can also drop this:

solana/validator/src/main.rs

Lines 1194 to 1196 in 24be850

	if matches.is_present("skip_poh_verify") {
	eprintln!("--skip-poh-verify is deprecated. Replace with --skip-verification.");
	}

[ilya-bobyr]

Thanks for jumping on this so quick. As for the help message of the now deprecated arg, you can leave it as is. Instead, add it to this list:

solana/validator/src/cli.rs

Line 1913 in 24be850

static ref DEPRECATED_ARGS_AND_HELP: Vec<(&'static str, &'static str)> = vec![

which will get iterated through and spit out uniform messages about deprecated args:

solana/validator/src/cli.rs

Lines 1718 to 1727 in 24be850

	pub fn warn_for_deprecated_arguments(matches: &ArgMatches) {
	for (arg, help) in DEPRECATED_ARGS_AND_HELP.iter() {
	if matches.is_present(arg) {
	warn!(
	"{}",
	format!("--{arg} is deprecated. {help}").replace('_', "-")
	);
	}
	}
	}

which means you can also drop this:

solana/validator/src/main.rs

Lines 1194 to 1196 in 24be850

	if matches.is_present("skip_poh_verify") {
	eprintln!("--skip-poh-verify is deprecated. Replace with --skip-verification.");
	}

I did a quick search, based on the get_deprecated_arguments(). Did not realize it was done via a separate list. Thank you for pointing it out.

Done.

Seems like accounts_db_skip_shrink is also missing from the DEPRECATED_ARGS_AND_HELP list.

Should I send a PR to add it?

[steviez]

I did a quick search, based on the get_deprecated_arguments(). Did not realize it was done via a separate list. Thank you for pointing it out.

No problem!

Seems like accounts_db_skip_shrink is also missing from the DEPRECATED_ARGS_AND_HELP list.
Should I send a PR to add it?

Yeah, good catch. Given that you're not the first person to miss this, might be worth a quick look to try to combine the two lists down to a single point. Don't have a great idea at the moment, but given that they're single use at startup, I think we can live with something that isn't the most elegant if it better helps us (engineers) to get both items updated (or single source somehow)

Also, code looks good to go, but CI is failing ... looks like you need a rebase on top of: #30897