poh_verify => run_verification: Rename to be more accurate #30811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30811 +/- ##
=======================================
Coverage 81.4% 81.4%
=======================================
Files 725 725
Lines 203465 203465
=======================================
+ Hits 165740 165748 +8
+ Misses 37725 37717 -8 |
KirillLykov
previously approved these changes
Mar 21, 2023
KirillLykov
previously approved these changes
Mar 22, 2023
`poh_verify` actually disables transaction signature, tick count and built in program argument verifications as well. It is somewhat confusing to call it `poh_verify`.
|
I just realized that there is also a |
steviez
reviewed
Mar 24, 2023
steviez
reviewed
Mar 24, 2023
ilya-bobyr
added a commit
that referenced
this pull request
Mar 27, 2023
Follow-up for commit 809041b Author: Illia Bobyr <[email protected]> Date: Wed Mar 22 11:03:30 2023 -0700 poh_verify => run_verification: Rename to be more accurate (#30811) `poh_verify` actually disables transaction signature, tick count and built in program argument verifications as well. It is somewhat confusing to call it `poh_verify`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
poh_verifyactually disables transaction signature, tick count and built in program argument verifications as well. It is somewhat confusing to call itpoh_verify.Summary of Changes
Renamed it to
run_verification, along with the CLI argument.Old argument is still accepted, but produces a deprecation message, suggesting a new name.