ci: fix do-audit don't report error #30728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
force-pushed
the
fix-audit-pipeline
branch
from
16a9807 to
f5220a4
Compare
|
will merge this one after #30727 |
t-nelson
reviewed
Mar 15, 2023
Co-authored-by: Trent Nelson <[email protected]>
|
^^^ it failed at the expected place atm 👻 |
yihau
force-pushed
the
fix-audit-pipeline
branch
from
1e68c25 to
9770f42
Compare
|
I think it looks correct now after I redirect stderr to stdout 👻
|
yihau
changed the title
|
i guess we actually need to fix the audit now 😅 |
|
@t-nelson sure! The fixed PR is here https://www.github.com/solana-labs/solana/pull/30727 and I'm waiting for it green 🤞 |
|
btw, we can make docker output prints like a terminal if we want. 3b551a6 |
|
🪖 |
mergify bot
pushed a commit
that referenced
this pull request
Mar 31, 2023
* ci: fix do-audit don't retport error * Update ci/do-audit.sh Co-authored-by: Trent Nelson <[email protected]> * use the latest suggestion * lint * redirect stderr to stdout * another solution --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit f8abc8d) # Conflicts: # ci/do-audit.sh
joeaba
added a commit
that referenced
this pull request
May 15, 2023
This is an automatic backport of pull request #30728 done by [Mergify](https://mergify.com). Cherry-pick of f8abc8d has failed: ``` On branch mergify/bp/v1.14/pr-30728 Your branch is up to date with 'origin/v1.14'. You are currently cherry-picking commit f8abc8d. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: ci/docker-run.sh Unmerged paths: (use "git add <file>..." to mark resolution) both modified: ci/do-audit.sh ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
jumpsiegel
pushed a commit
to firedancer-io/solana
that referenced
this pull request
May 30, 2023
* ci: fix do-audit don't retport error * Update ci/do-audit.sh Co-authored-by: Trent Nelson <[email protected]> * use the latest suggestion * lint * redirect stderr to stdout * another solution --------- Co-authored-by: Trent Nelson <[email protected]> (cherry picked from commit f8abc8d) # Conflicts: # ci/do-audit.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #