Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates tempfile to 3.4.0 #30727

Merged
merged 1 commit into from
Mar 16, 2023
Merged

updates tempfile to 3.4.0 #30727

merged 1 commit into from
Mar 16, 2023

Conversation

behzadnouri
Copy link
Contributor

Problem

Patching below rustsec advisory:

Crate:     remove_dir_all
Version:   0.5.3
Title:     Race Condition Enabling Link Following and Time-of-check Time-of-use (TOCTOU)
Date:      2023-02-24
ID:        RUSTSEC-2023-0018
URL:       https://rustsec.org/advisories/RUSTSEC-2023-0018
Solution:  Upgrade to >=0.8.0

Summary of Changes

updated tempfile to 3.4.0

@behzadnouri behzadnouri requested review from yihau and t-nelson March 15, 2023 15:35
@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Mar 15, 2023
yihau
yihau previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yihau yihau mentioned this pull request Mar 15, 2023
Merged
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Mar 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

automerge label removed due to a CI failure

@yihau
Copy link
Member

yihau commented Mar 15, 2023

@dmakarov is it okay to change the threshold https://github.com/solana-labs/solana/blob/master/ci/test-stable.sh#L122 to 14? I found we solve this similar issue by increasing this value last time
conversation: https://discord.com/channels/428295358100013066/439194979856809985/1082439305714225162
pr: https://www.github.com/solana-labs/solana/pull/30353

@dmakarov
Copy link
Contributor

@dmakarov is it okay to change the threshold https://github.com/solana-labs/solana/blob/master/ci/test-stable.sh#L122 to 14? I found we solve this similar issue by increasing this value last time
conversation: https://discord.com/channels/428295358100013066/439194979856809985/1082439305714225162
pr: https://www.github.com/solana-labs/solana/pull/30353

Yes, it’s ok. I’ll see if I can fix it back to lower rebuild number later.

@behzadnouri
updates tempfile to 3.4.0
52f95ae 
Patching below rustsec advisory:

    Crate:     remove_dir_all
    Version:   0.5.3
    Title:     Race Condition Enabling Link Following and Time-of-check Time-of-use (TOCTOU)
    Date:      2023-02-24
    ID:        RUSTSEC-2023-0018
    URL:       https://rustsec.org/advisories/RUSTSEC-2023-0018
    Solution:  Upgrade to >=0.8.0
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #30727 (52f95ae) into master (65cd552) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #30727     +/-   ##
=========================================
- Coverage    81.7%    81.6%   -0.1%     
=========================================
  Files         723      723             
  Lines      201802   201802             
=========================================
- Hits       164891   164808     -83     
- Misses      36911    36994     +83

@behzadnouri behzadnouri requested a review from yihau March 15, 2023 20:24
@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Mar 15, 2023
@t-nelson t-nelson merged commit 3cc74a6 into solana-labs:master Mar 16, 2023
@behzadnouri behzadnouri deleted the tempfile-update branch March 16, 2023 12:29
yihau added a commit that referenced this pull request Mar 31, 2023
@yihau
bump tempfile to 3.4.0 (#30727)
c0887d3
@yihau yihau mentioned this pull request Mar 31, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label May 9, 2023
mergify bot pushed a commit that referenced this pull request May 9, 2023
@behzadnouri @mergify
updates tempfile to 3.4.0 (#30727)
86144c7 
Patching below rustsec advisory:

    Crate:     remove_dir_all
    Version:   0.5.3
    Title:     Race Condition Enabling Link Following and Time-of-check Time-of-use (TOCTOU)
    Date:      2023-02-24
    ID:        RUSTSEC-2023-0018
    URL:       https://rustsec.org/advisories/RUSTSEC-2023-0018
    Solution:  Upgrade to >=0.8.0

(cherry picked from commit 3cc74a6)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	bench-tps/Cargo.toml
#	ci/test-stable.sh
#	programs/bpf/Cargo.lock
@mergify mergify bot mentioned this pull request May 9, 2023
Closed
brooksprumo pushed a commit to brooksprumo/solana that referenced this pull request May 9, 2023
@yihau @brooksprumo
bump tempfile to 3.4.0 (solana-labs#30727)
4831df5
@t-nelson t-nelson mentioned this pull request May 9, 2023
Closed
@brooksprumo brooksprumo mentioned this pull request May 9, 2023
Closed
jumpsiegel pushed a commit to firedancer-io/solana that referenced this pull request May 30, 2023
@yihau @jumpsiegel
bump tempfile to 3.4.0 (solana-labs#30727)
673cf65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-nelson t-nelson t-nelson approved these changes

@yihau yihau Awaiting requested review from yihau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@behzadnouri @yihau @dmakarov @t-nelson @brooksprumo